Skip to content
This repository has been archived by the owner on May 10, 2023. It is now read-only.

Issue 41 #42

Merged
merged 10 commits into from
Aug 31, 2019
Merged

Issue 41 #42

merged 10 commits into from
Aug 31, 2019

Conversation

garciparedes
Copy link
Owner

PR Details

Description

This pull request extends the deployment script, adding syntax and type hinting validations. Also, solves the bad ones to be at successful state.

Related Issue

#41

Motivation and Context

The code quality should be one priority around this project.

How Has This Been Tested

This pull request generates new tests.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@garciparedes garciparedes self-assigned this Aug 31, 2019
@codecov
Copy link

codecov bot commented Aug 31, 2019 •
edited
Loading

Codecov Report

Merging #42 into master will increase coverage by 0.33%.
The diff coverage is 83.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
+ Coverage   84.11%   84.45%   +0.33%     
==========================================
  Files          56       54       -2     
  Lines        1492     1505      +13     
==========================================
+ Hits         1255     1271      +16     
+ Misses        237      234       -3
Impacted Files Coverage Δ
jinete/models/__init__.py 100% <ø> (ø) ⬆️
jinete/storers/plots/__init__.py 100% <ø> (ø) ⬆️
jinete/algorithms/metaheuristics/grasp.py 57.14% <0%> (+15.2%) ⬆️
jinete/algorithms/utils/crossers/randomized.py 38.23% <0%> (ø) ⬆️
jinete/dispatchers/static.py 100% <100%> (ø) ⬆️
jinete/storers/formatters/abc.py 77.27% <100%> (ø) ⬆️
jinete/models/jobs.py 75.86% <100%> (+2.78%) ⬆️
jinete/algorithms/utils/crossers/abc.py 86.44% <100%> (+1.53%) ⬆️
jinete/storers/plots/graph.py 91.3% <100%> (ø) ⬆️
jinete/models/constants.py 81.63% <100%> (-0.37%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 059b7ec...0787287. Read the comment docs.

@garciparedes garciparedes merged commit c1db994 into master Aug 31, 2019
@garciparedes garciparedes deleted the issue-41 branch August 31, 2019 12:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@garciparedes garciparedes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@garciparedes